Skip to content

Render overview on route pages#597

Merged
andrii-balitskyi merged 1 commit into
mainfrom
andrii/cx-316-render-overview-on-route-pages
May 22, 2025
Merged

Render overview on route pages#597
andrii-balitskyi merged 1 commit into
mainfrom
andrii/cx-316-render-overview-on-route-pages

Conversation

@andrii-balitskyi

Copy link
Copy Markdown
Contributor

No description provided.

@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner May 16, 2025 12:11

export interface ApiRouteLayoutContext {
title: string
description: string

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description wasn't used previously, so it's safe to rename it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DebbieAtSeam would we want both a description and overview for route pages?
image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@razor-x So, I'm not sure that both are being used now, but does it make sense to future-proof and allow for the possibility of both page description and overview?

@andrii-balitskyi

andrii-balitskyi commented May 16, 2025

Copy link
Copy Markdown
Contributor Author

Nothing was rendered because no route has an overview right now defined in src/data/paths.yaml. Only /acs, which is a namespace, has an overview

@andrii-balitskyi andrii-balitskyi requested a review from razor-x May 20, 2025 08:02
@andrii-balitskyi andrii-balitskyi merged commit 74d682a into main May 22, 2025
12 checks passed
@andrii-balitskyi andrii-balitskyi deleted the andrii/cx-316-render-overview-on-route-pages branch May 22, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants